From fd5483d5103762d0e50055637135faaeaaca81da Mon Sep 17 00:00:00 2001 From: bobtajson <152420524+bobtajson@users.noreply.github.com> Date: Thu, 23 Oct 2025 10:25:23 +0200 Subject: [PATCH 1/5] Update metrics.py --- atroposlib/utils/metrics.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/atroposlib/utils/metrics.py b/atroposlib/utils/metrics.py index 0a1c75d4..cf792113 100644 --- a/atroposlib/utils/metrics.py +++ b/atroposlib/utils/metrics.py @@ -4,7 +4,7 @@ import numpy as np def get_std_min_max_avg(name: str, data: list, metrics_dict: dict) -> dict: """ Calculate the standard deviation, minimum, maximum, and average of a list of numbers. - Adds it to the wandb dict for logging. + Adds it to the metrics dict for logging. Args: data (list): A list of numbers. From 16c6897b21c56d1b600ea1426b56f04c0d757d51 Mon Sep 17 00:00:00 2001 From: bobtajson <152420524+bobtajson@users.noreply.github.com> Date: Thu, 23 Oct 2025 10:26:03 +0200 Subject: [PATCH 2/5] Update metrics.py --- atroposlib/utils/metrics.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/atroposlib/utils/metrics.py b/atroposlib/utils/metrics.py index cf792113..082ea370 100644 --- a/atroposlib/utils/metrics.py +++ b/atroposlib/utils/metrics.py @@ -7,7 +7,9 @@ def get_std_min_max_avg(name: str, data: list, metrics_dict: dict) -> dict: Adds it to the metrics dict for logging. Args: - data (list): A list of numbers. + name: The base name for the metrics keys. + data: A list of numbers to compute statistics from. + metrics_dict: Dictionary to add the computed metrics to. Returns: dict: A dictionary containing the standard deviation, minimum, maximum, and average. From 3157e6d7e8b7e0a7ce8750f61f8a5f5b09edc2f1 Mon Sep 17 00:00:00 2001 From: bobtajson <152420524+bobtajson@users.noreply.github.com> Date: Thu, 23 Oct 2025 10:26:21 +0200 Subject: [PATCH 3/5] Update metrics.py --- atroposlib/utils/metrics.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/atroposlib/utils/metrics.py b/atroposlib/utils/metrics.py index 082ea370..06066e21 100644 --- a/atroposlib/utils/metrics.py +++ b/atroposlib/utils/metrics.py @@ -12,7 +12,7 @@ def get_std_min_max_avg(name: str, data: list, metrics_dict: dict) -> dict: metrics_dict: Dictionary to add the computed metrics to. Returns: - dict: A dictionary containing the standard deviation, minimum, maximum, and average. + The updated metrics dictionary with added statistics (mean, std, max, min). """ metrics_dict[f"{name}_mean"] = np.mean(data) metrics_dict[f"{name}_std"] = np.std(data) From 59ad9643d6c8d0b0702a09d3b833dafb934c06de Mon Sep 17 00:00:00 2001 From: bobtajson <152420524+bobtajson@users.noreply.github.com> Date: Thu, 23 Oct 2025 10:26:51 +0200 Subject: [PATCH 4/5] Update type_definitions.py --- atroposlib/type_definitions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/atroposlib/type_definitions.py b/atroposlib/type_definitions.py index bf3ffd3c..b435f677 100644 --- a/atroposlib/type_definitions.py +++ b/atroposlib/type_definitions.py @@ -74,7 +74,7 @@ GameHistory = List[GameStep] class EvaluationConfigGeneral(TypedDict): """Configuration section of evaluation results.""" - total_evaluation_time_secondes: str + total_evaluation_time_seconds: str model_name: Optional[str] generation_parameters: Dict[str, Any] From 6e2d36bd2a23859d71f3c4273e49784fb1a6b78d Mon Sep 17 00:00:00 2001 From: bobtajson <152420524+bobtajson@users.noreply.github.com> Date: Thu, 23 Oct 2025 10:27:23 +0200 Subject: [PATCH 5/5] Update base.py --- atroposlib/envs/base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/atroposlib/envs/base.py b/atroposlib/envs/base.py index 6ee5f2b8..b94f0995 100644 --- a/atroposlib/envs/base.py +++ b/atroposlib/envs/base.py @@ -721,7 +721,7 @@ class BaseEnv(ABC): eval_result = { "config_general": { "model_name": model_name, - "total_evaluation_time_secondes": str(end_time - start_time), + "total_evaluation_time_seconds": str(end_time - start_time), "generation_parameters": merged_gen_params, }, "results": {