formatting

This commit is contained in:
Andreas Koepf 2025-01-24 10:34:07 +01:00
parent 98988c8481
commit 20069b2a7d
37 changed files with 504 additions and 666 deletions

View file

@ -1,5 +1,7 @@
import pytest
from random import Random
import pytest
from reasoning_gym.arithmetic.basic_arithmetic import BasicArithmeticDataset, BasicArithmeticDatasetConfig
@ -8,11 +10,11 @@ def test_arithmetic_dataset_config_validation():
with pytest.raises(AssertionError):
config = BasicArithmeticDatasetConfig(min_terms=0)
config.validate()
with pytest.raises(AssertionError):
config = BasicArithmeticDatasetConfig(min_terms=3, max_terms=2)
config.validate()
with pytest.raises(AssertionError):
config = BasicArithmeticDatasetConfig(operators=["^"]) # Invalid operator
config.validate()
@ -23,30 +25,23 @@ def test_arithmetic_dataset_deterministic():
config = BasicArithmeticDatasetConfig(seed=42, size=10)
dataset1 = BasicArithmeticDataset(config)
dataset2 = BasicArithmeticDataset(config)
for i in range(len(dataset1)):
assert dataset1[i] == dataset2[i]
def test_arithmetic_dataset_items():
"""Test basic properties of generated items"""
config = BasicArithmeticDatasetConfig(
min_terms=2,
max_terms=4,
min_digits=1,
max_digits=2,
size=100,
seed=42
)
config = BasicArithmeticDatasetConfig(min_terms=2, max_terms=4, min_digits=1, max_digits=2, size=100, seed=42)
dataset = BasicArithmeticDataset(config)
for i in range(len(dataset)):
item = dataset[i]
assert isinstance(item, dict)
assert "question" in item
assert "answer" in item
assert "metadata" in item
# Verify the answer matches the expression
expression = item["metadata"]["expression"]
answer = eval(expression) # Safe here as we control the expression
@ -62,11 +57,11 @@ def test_arithmetic_dataset_format_styles():
min_terms=2,
max_terms=3, # Keep expressions simple for testing
min_digits=1,
max_digits=2
max_digits=2,
)
dataset = BasicArithmeticDataset(config)
assert all(item["question"].endswith("=") for item in dataset)
config.format_style = "natural"
dataset = BasicArithmeticDataset(config)
assert all("=" not in item["question"] for item in dataset)
@ -74,24 +69,19 @@ def test_arithmetic_dataset_format_styles():
def test_arithmetic_dataset_iteration():
"""Test that iteration respects dataset size"""
config = BasicArithmeticDatasetConfig(
min_terms=2,
max_terms=2,
size=5, # Small size for testing
seed=42
)
config = BasicArithmeticDatasetConfig(min_terms=2, max_terms=2, size=5, seed=42) # Small size for testing
dataset = BasicArithmeticDataset(config)
# Test manual iteration
items = []
for item in dataset:
items.append(item)
assert len(items) == config.size, "Iterator should yield exactly size items"
# Test list conversion
items = list(dataset)
assert len(items) == config.size, "Iterator should yield exactly size items"
# Test multiple iterations
first_items = list(dataset)
second_items = list(dataset)