formatting

This commit is contained in:
Andreas Koepf 2025-01-24 10:34:07 +01:00
parent 98988c8481
commit 20069b2a7d
37 changed files with 504 additions and 666 deletions

View file

@ -1,7 +1,9 @@
import pytest
from math import lcm
from functools import reduce
from reasoning_gym.arithmetic import LCMDataset, LCMConfig
from math import lcm
import pytest
from reasoning_gym.arithmetic import LCMConfig, LCMDataset
def test_lcm_config_validation():
@ -9,15 +11,15 @@ def test_lcm_config_validation():
with pytest.raises(AssertionError):
config = LCMConfig(min_numbers=1) # Should be >= 2
config.validate()
with pytest.raises(AssertionError):
config = LCMConfig(min_numbers=3, max_numbers=2) # max should be >= min
config.validate()
with pytest.raises(AssertionError):
config = LCMConfig(min_value=0) # Should be positive
config.validate()
with pytest.raises(AssertionError):
config = LCMConfig(min_value=100, max_value=50) # max should be > min
config.validate()
@ -28,7 +30,7 @@ def test_lcm_deterministic():
config = LCMConfig(seed=42, size=10)
dataset1 = LCMDataset(config)
dataset2 = LCMDataset(config)
for i in range(len(dataset1)):
assert dataset1[i] == dataset2[i]
@ -36,32 +38,27 @@ def test_lcm_deterministic():
def test_lcm_items():
"""Test basic properties of generated items"""
config = LCMConfig(
min_numbers=2,
max_numbers=4,
min_value=1,
max_value=20, # Keep small for testing
size=50,
seed=42
min_numbers=2, max_numbers=4, min_value=1, max_value=20, size=50, seed=42 # Keep small for testing
)
dataset = LCMDataset(config)
for i in range(len(dataset)):
item = dataset[i]
assert isinstance(item, dict)
assert "question" in item
assert "answer" in item
assert "metadata" in item
# Verify the numbers and result are in metadata
metadata = item["metadata"]
assert "numbers" in metadata
assert "result" in metadata
# Verify the numbers are within configured range
numbers = metadata["numbers"]
assert all(config.min_value <= n <= config.max_value for n in numbers)
assert config.min_numbers <= len(numbers) <= config.max_numbers
# Verify the LCM calculation is correct
result = metadata["result"]
assert str(result) == item["answer"]
@ -70,16 +67,9 @@ def test_lcm_items():
def test_lcm_number_ranges():
"""Test that generated numbers respect value constraints"""
config = LCMConfig(
min_numbers=2,
max_numbers=2,
min_value=5,
max_value=15,
size=20,
seed=42
)
config = LCMConfig(min_numbers=2, max_numbers=2, min_value=5, max_value=15, size=20, seed=42)
dataset = LCMDataset(config)
for i in range(len(dataset)):
item = dataset[i]
numbers = item["metadata"]["numbers"]
@ -90,17 +80,17 @@ def test_lcm_iteration():
"""Test that iteration works correctly"""
config = LCMConfig(size=5, seed=42)
dataset = LCMDataset(config)
# Test manual iteration
items = []
for item in dataset:
items.append(item)
assert len(items) == config.size
# Test list conversion
items = list(dataset)
assert len(items) == config.size
# Test multiple iterations yield same results
first_items = list(dataset)
second_items = list(dataset)
@ -109,31 +99,24 @@ def test_lcm_iteration():
def test_lcm_special_cases():
"""Test some special LCM cases"""
config = LCMConfig(
min_numbers=2,
max_numbers=2,
min_value=1,
max_value=20,
size=100,
seed=42
)
config = LCMConfig(min_numbers=2, max_numbers=2, min_value=1, max_value=20, size=100, seed=42)
dataset = LCMDataset(config)
# Track if we see some interesting LCM cases
seen_equal_to_product = False # When numbers are coprime
seen_less_than_product = False # When numbers share factors
for i in range(len(dataset)):
item = dataset[i]
numbers = item["metadata"]["numbers"]
result = int(item["answer"])
product = reduce(lambda x, y: x * y, numbers)
if result == product:
seen_equal_to_product = True
if result < product:
seen_less_than_product = True
# With enough samples, we should see both cases
assert seen_equal_to_product, "Expected to see some coprime numbers (LCM = product)"
assert seen_less_than_product, "Expected to see some numbers with common factors (LCM < product)"