open-thought/reasoning-gym
1
0
Fork 0
mirror of https://github.com/open-thought/reasoning-gym.git synced 2026-04-24 17:05:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Rename ArithmeticDataset to BasicArithmeticDataset

Browse source
This commit is contained in:
Andreas Koepf 2025-01-24 10:31:26 +01:00
parent 44fd0d4a25
commit 98988c8481
7 changed files with 27 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

28
tests/test_arithmetic.py
View file

@ -1,28 +1,28 @@
import pytest
from random import Random
from reasoning_gym.arithmetic.basic_arithmetic import ArithmeticDataset, ArithmeticDatasetConfig
from reasoning_gym.arithmetic.basic_arithmetic import BasicArithmeticDataset, BasicArithmeticDatasetConfig
def test_arithmetic_dataset_config_validation():
"""Test that invalid configs raise appropriate errors"""
with pytest.raises(AssertionError):
config = ArithmeticDatasetConfig(min_terms=0)
config = BasicArithmeticDatasetConfig(min_terms=0)
config.validate()
with pytest.raises(AssertionError):
config = ArithmeticDatasetConfig(min_terms=3, max_terms=2)
config = BasicArithmeticDatasetConfig(min_terms=3, max_terms=2)
config.validate()
with pytest.raises(AssertionError):
config = ArithmeticDatasetConfig(operators=["^"]) # Invalid operator
config = BasicArithmeticDatasetConfig(operators=["^"]) # Invalid operator
config.validate()
def test_arithmetic_dataset_deterministic():
"""Test that dataset generates same items with same seed"""
config = ArithmeticDatasetConfig(seed=42, size=10)
dataset1 = ArithmeticDataset(config)
dataset2 = ArithmeticDataset(config)
config = BasicArithmeticDatasetConfig(seed=42, size=10)
dataset1 = BasicArithmeticDataset(config)
dataset2 = BasicArithmeticDataset(config)
for i in range(len(dataset1)):
assert dataset1[i] == dataset2[i]
@ -30,7 +30,7 @@ def test_arithmetic_dataset_deterministic():
def test_arithmetic_dataset_items():
"""Test basic properties of generated items"""
config = ArithmeticDatasetConfig(
config = BasicArithmeticDatasetConfig(
min_terms=2,
max_terms=4,
min_digits=1,
@ -38,7 +38,7 @@ def test_arithmetic_dataset_items():
size=100,
seed=42
)
dataset = ArithmeticDataset(config)
dataset = BasicArithmeticDataset(config)
for i in range(len(dataset)):
item = dataset[i]
@ -55,7 +55,7 @@ def test_arithmetic_dataset_items():
def test_arithmetic_dataset_format_styles():
"""Test different question format styles"""
config = ArithmeticDatasetConfig(
config = BasicArithmeticDatasetConfig(
size=10,
seed=42,
format_style="simple",
@ -64,23 +64,23 @@ def test_arithmetic_dataset_format_styles():
min_digits=1,
max_digits=2
)
dataset = ArithmeticDataset(config)
dataset = BasicArithmeticDataset(config)
assert all(item["question"].endswith("=") for item in dataset)
config.format_style = "natural"
dataset = ArithmeticDataset(config)
dataset = BasicArithmeticDataset(config)
assert all("=" not in item["question"] for item in dataset)
def test_arithmetic_dataset_iteration():
"""Test that iteration respects dataset size"""
config = ArithmeticDatasetConfig(
config = BasicArithmeticDatasetConfig(
min_terms=2,
max_terms=2,
size=5, # Small size for testing
seed=42
)
dataset = ArithmeticDataset(config)
dataset = BasicArithmeticDataset(config)
# Test manual iteration
items = []