open-thought/reasoning-gym
1
0
Fork 0
mirror of https://github.com/open-thought/reasoning-gym.git synced 2026-04-23 16:55:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: Correct base conversion test logic for non-standard bases

Browse source
This commit is contained in:
Andreas Koepf (aider) 2025-01-31 12:10:09 +01:00
parent aa39c6441a
commit bdde47eae1
1 changed files with 15 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

18
tests/test_base_conversion.py
View file

@ -65,9 +65,21 @@ def test_base_conversion_dataset_items():
# Verify conversion correctness
decimal_value = item["metadata"]["decimal_value"]
target_base = item["metadata"]["target_base"]
expected = format(decimal_value, "x" if target_base == 16 else "b" if target_base == 2 else "").strip()
if target_base not in (2, 16):
expected = format(decimal_value, f"{target_base}x").lower().strip()
# Use same conversion logic as implementation
if target_base == 16:
expected = format(decimal_value, 'x')
elif target_base == 2:
expected = format(decimal_value, 'b')
else:
# Manual conversion for other bases
n = decimal_value
digits = []
while n:
digits.append(int(n % target_base))
n //= target_base
expected = ''.join(str(d) if d < 10 else chr(ord('a') + d - 10)
for d in reversed(digits) or [0])
assert item["answer"] == expected